From c54020305d83990d10b5404c4e67858963cfde5c Mon Sep 17 00:00:00 2001 From: Bob Polis Date: Tue, 10 Dec 2024 17:00:28 +0100 Subject: [PATCH] Migrate to normal project structure --- Makefile | 288 ++++++++++++++++++++++++++++++++++++++++-- man/man1/valid-utf8.1 | 59 +++++++++ premake.make | 31 +++++ src/main.cpp | 74 +++++++++++ src/precomp.hpp | 127 +++++++++++++++++++ src/version.cpp | 19 +++ src/version.hpp | 8 ++ tests/Makefile | 1 + tests/postmake.make | 6 + tests/premake.make | 5 + tests/src/main.cpp | 8 ++ tests/src/precomp.hpp | 1 + 12 files changed, 614 insertions(+), 13 deletions(-) create mode 100644 man/man1/valid-utf8.1 create mode 100644 premake.make create mode 100644 src/main.cpp create mode 100644 src/precomp.hpp create mode 100644 src/version.cpp create mode 100644 src/version.hpp create mode 120000 tests/Makefile create mode 100644 tests/postmake.make create mode 100644 tests/premake.make create mode 100644 tests/src/main.cpp create mode 120000 tests/src/precomp.hpp diff --git a/Makefile b/Makefile index 53d56c7..e4e5bdc 100644 --- a/Makefile +++ b/Makefile @@ -1,31 +1,293 @@ -LDLIBS := -lscstring +include premake.make -PROJ := $(shell basename $$(pwd)) +# git commit hash and version for this build +COMMIT-HASH != git log 2>/dev/null | sed -e '1s/^commit //;q' +COMMIT := "const char* commit = \"$(COMMIT-HASH)\";" +VERSION := "const char* version = \"$(MAJOR).$(MINOR).$(PATCH)\";" -SRCS := $(wildcard *.cpp) -OBJS := $(SRCS:.cpp=.o) -DEPS := $(SRCS:.cpp=.dep) +# some important install locations +PREFIX ?= /usr/local +BINDIR ?= $(PREFIX)/bin +CONFIGDIR ?= $(PREFIX)/etc +INCLUDEDIR ?= $(PREFIX)/include +LIBDIR ?= $(PREFIX)/lib +MANDIR ?= $(PREFIX)/man +DATADIR ?= $(PREFIX)/share/$(PROJ) +DOCDIR ?= $(DATADIR)/doc +# setup naming and versioning for library product +ifeq ($(UNAME_S), Darwin) + LINKERNAME := $(PROJ).dylib + SONAME := $(PROJ).$(MAJOR).dylib + REALNAME := $(LINKERNAME) +else ifeq ($(UNAME_S), OpenBSD) + REALNAME := $(PROJ).so.$(MAJOR).$(MINOR) +else ifeq ($(UNAME_S), Linux) + LINKERNAME := $(PROJ).so + SONAME := $(LINKERNAME).$(MAJOR) + REALNAME := $(SONAME).$(MINOR).$(PATCH) +endif +STATICLIB := $(PROJ).a + +# select default compiler CXX ?= g++ +# setup compiler flags and build config CXXFLAGS += -Wshadow -Wall -Wpedantic -Wextra -Wno-unused-parameter -CXXFLAGS += -g3 -std=c++20 -ifeq ($(DEBUG),1) +CXXFLAGS += -g3 -fPIC +ifeq ($(DEBUG), 1) CXXFLAGS += -DDEBUG -O0 + CONFIG := debug else CXXFLAGS += -DNDEBUG -O3 + CONFIG := release endif -%.o: %.cpp - $(CXX) $(CXXFLAGS) -MMD -MP -MT $@ -MF $*.dep -c $< +# setup build locations +OUTDIR := build/$(CONFIG) +BUILDDIR := build/obj +BIN := $(OUTDIR)/$(PROJ) + +# define sources and derived files +# allow for extra sources defined in premake.make +SRCS += $(notdir $(wildcard src/*.cpp)) +OBJS := $(addprefix $(BUILDDIR)/, $(SRCS:.cpp=.o)) +DEPS := $(addprefix $(BUILDDIR)/, $(SRCS:.cpp=.dep)) +HDRS ?= $(wildcard src/*.hpp) +MANS := $(addprefix $(PREFIX)/, $(wildcard man/man*/*)) + +# if project supports plugins, link to libdl where needed +ifdef PLUGINS +ifeq ($(UNAME_S),Darwin) + LDLIBS += -ldl +else ifeq ($(UNAME_S),Linux) + LDLIBS += -ldl +endif +endif + +# pattern rules =========================================================== + +$(BUILDDIR)/%.o: src/%.cpp +ifeq ($(PRECOMPILE), 1) + $(CXX) $(CXXFLAGS) -o $@ -include precomp.hpp -MMD -MP -MT $@ -MF $(BUILDDIR)/$*.dep -c $< +else + $(CXX) $(CXXFLAGS) -o $@ -MMD -MP -MT $@ -MF $(BUILDDIR)/$*.dep -c $< +endif %.dep: ; -$(PROJ): $(OBJS) - $(CXX) $(LDFLAGS) -o $(PROJ) $(OBJS) $(LDLIBS) +$(MANDIR)/man1/%: man/man1/% + install -m 0644 $< $@ +$(MANDIR)/man3/%: man/man3/% + install -m 0644 $< $@ + +$(MANDIR)/man5/%: man/man5/% + install -m 0644 $< $@ + +# =========================================================== pattern rules + +# targets ================================================================= + +.PHONY: all commit-hash version plugins test clean dist-clean install-plugins \ +install install-data uninstall-data uninstall-plugins uninstall + +# main target +ifeq ($(PRODUCT), tool) +all: $(BUILDDIR) $(OUTDIR) commit-hash version plugins $(BIN) +else ifeq ($(PRODUCT), lib) +all: $(BUILDDIR) $(OUTDIR) commit-hash version plugins $(OUTDIR)/$(REALNAME) $(OUTDIR)/$(STATICLIB) +endif + +$(BUILDDIR): + mkdir -p $@ + +$(OUTDIR): + mkdir -p $@ + +# product build rules +ifeq ($(PRODUCT), tool) # -------------------------------------------- tool + +ifeq ($(PRECOMPILE), 1) +$(BIN): precomp.hpp.gch $(OBJS) +else +$(BIN): $(OBJS) +endif + $(CXX) -o $(BIN) $(LDFLAGS) $(OBJS) $(LDLIBS) + @ln -sf $(BIN) $(PROJ) + +endif # -------------------------------------------------------------- tool + +ifeq ($(PRODUCT), lib) # ---------------------------------------------- lib + +ifeq ($(PRECOMPILE), 1) +$(OUTDIR)/$(REALNAME): precomp.hpp.gch $(OBJS) +else +$(OUTDIR)/$(REALNAME): $(OBJS) +endif +ifeq ($(UNAME_S),Darwin) + $(CXX) -dynamiclib -o $(OUTDIR)/$(REALNAME) -current_version $(MAJOR) -compatibility_version $(MINOR) $(LDFLAGS) $(OBJS) $(LDLIBS) +else ifeq ($(UNAME_S),OpenBSD) + $(CXX) -g -shared -Wl,-soname,$(REALNAME) -o $(OUTDIR)/$(REALNAME) $(LDFLAGS) $(OBJS) $(LDLIBS) +else ifeq ($(UNAME_S),Linux) + $(CXX) -g -shared -Wl,-soname,$(SONAME) -o $(OUTDIR)/$(REALNAME) $(LDFLAGS) $(OBJS) $(LDLIBS) +endif + +$(OUTDIR)/$(STATICLIB): $(OBJS) + ar r $(OUTDIR)/$(STATICLIB) $(OBJS) + +ifeq ($(GENERATELIBHEADER),1) +$(OUTDIR)/$(PROJ).hpp: $(HDRS) + @echo updating $(OUTDIR)/$(PROJ).hpp + @cp /dev/null $(OUTDIR)/$(PROJ).hpp + @for h in $(HDRS); \ + do \ + sed '/@exclude/d' $$h >> $(OUTDIR)/$(PROJ).hpp; \ + done +endif + +endif # --------------------------------------------------------------- lib + +# get generated dependencies, if any -include $(DEPS) -.PHONY: clean +commit-hash: + @if ! echo $(COMMIT) | diff -q src/commit.inc - >/dev/null 2>&1 ;\ + then \ + echo $(COMMIT) > src/commit.inc ;\ + fi + +version: + @if ! echo $(VERSION) | diff -q src/version.inc - >/dev/null 2>&1 ;\ + then \ + echo $(VERSION) > src/version.inc ;\ + fi + +$(BUILDDIR)/version.o: src/version.inc src/commit.inc + +precomp.hpp.gch: src/precomp.hpp + $(CXX) $< $(CXXFLAGS) -o $@ + +plugins: +ifdef PLUGINS + @for plug in $(PLUGINS) ;\ + do \ + $(MAKE) -C $$plug ;\ + done +endif + +test: + $(MAKE) -C tests && tests/tests + clean: - rm -f $(OBJS) $(DEPS) $(PROJ) + rm -rf $(BUILDDIR) tests/build tests/tests tests/src/commit.inc tests/src/version.inc +ifdef PLUGINS + @for plug in $(PLUGINS) ;\ + do \ + $(MAKE) -C $$plug clean ;\ + done +endif + +dist-clean: clean + rm -rf build $(PROJ) src/commit.inc src/version.inc precomp.hpp.gch + +$(MANDIR)/man1: + install -m 0755 -d $@ + +$(MANDIR)/man3: + install -m 0755 -d $@ + +$(MANDIR)/man5: + install -m 0755 -d $@ + +$(DATADIR): + install -m 0755 -d $@ + +# (un)install targets + +ifdef DATAFILES +install-data: $(DATADIR) + install -m 0644 $(DATAFILES) $(DATADIR) +else +install-data: +endif + +uninstall-data: + rm -rf $(DATADIR) + +install-plugins: +ifdef PLUGINS + @for plug in $(PLUGINS) ;\ + do \ + $(MAKE) -C $$plug install ;\ + done +endif + +uninstall-plugins: +ifdef PLUGINS + @for plug in $(PLUGINS) ;\ + do \ + $(MAKE) -C $$plug uninstall ;\ + done +endif + +ifeq ($(PRODUCT), tool) # -------------------------------------------- tool + +$(BINDIR): + install -m 0755 -d $@ + +install: $(MANDIR)/man1 $(MANDIR)/man3 $(MANDIR)/man5 $(BINDIR) $(MANS) install-data install-plugins + install -m 0755 $(BIN) $(BINDIR) + +uninstall: uninstall-data uninstall-plugins + rm -f $(BINDIR)/$(PROJ) $(MANS) + +endif # -------------------------------------------------------------- tool + +ifeq ($(PRODUCT), lib) # ---------------------------------------------- lib + +$(LIBDIR): + install -m 0755 -d $@ + +$(INCLUDEDIR): + install -m 0755 -d $@ + +$(INCLUDEDIR)/$(PROJ): + install -m 0755 -d $@ + +ifeq ($(GENERATELIBHEADER), 1) +install: $(MANDIR)/man1 $(MANDIR)/man3 $(MANDIR)/man5 $(LIBDIR) $(INCLUDEDIR) $(MANS) $(OUTDIR)/$(PROJ).hpp install-data install-plugins + install -m 0644 $(OUTDIR)/$(PROJ).hpp $(INCLUDEDIR) +else +install: $(MANDIR)/man1 $(MANDIR)/man3 $(MANDIR)/man5 $(LIBDIR) $(INCLUDEDIR) $(MANS) $(INCLUDEDIR)/$(PROJ) install-data install-plugins + install -m 0644 $(HDRS) $(INCLUDEDIR)/$(PROJ) +endif + install -m 0644 $(OUTDIR)/$(REALNAME) $(LIBDIR) + install -m 0644 $(OUTDIR)/$(STATICLIB) $(LIBDIR) +ifeq ($(UNAME_S), Darwin) + cd $(LIBDIR) && ln -sf $(REALNAME) $(SONAME) +else ifeq ($(UNAME_S), Linux) +ifeq ($(USER), root) + ldconfig +else + cd $(LIBDIR) && ln -sf $(REALNAME) $(SONAME) +endif + cd $(LIBDIR) && ln -sf $(SONAME) $(LINKERNAME) +else ifeq ($(UNAME_S), OpenBSD) + ldconfig -R +endif + +uninstall: uninstall-data uninstall-plugins + rm -rf $(INCLUDEDIR)/$(PROJ).hpp $(INCLUDEDIR)/$(PROJ) $(MANS) $(LIBDIR)/$(STATICLIB) $(LIBDIR)/$(REALNAME) $(LIBDIR)/$(SONAME) $(LIBDIR)/$(LINKERNAME) +ifeq ($(UNAME_S), Linux) + ldconfig +else ifeq ($(UNAME_S), OpenBSD) + ldconfig -R +endif + +endif # --------------------------------------------------------------- lib + +# ================================================================= targets + +# project-specific targets go in here +-include postmake.make diff --git a/man/man1/valid-utf8.1 b/man/man1/valid-utf8.1 new file mode 100644 index 0000000..cb201bd --- /dev/null +++ b/man/man1/valid-utf8.1 @@ -0,0 +1,59 @@ +.Dd $Mdocdate$ +.Dt valid-utf8 1 +.Os +.Sh NAME +.Nm valid-utf8 +.Nd one line about what it does +.\" .Sh LIBRARY +.\" For sections 2, 3, and 9 only. +.\" Not used in OpenBSD. +.Sh SYNOPSIS +.Nm +.Fl h +.Nm +.Fl \-version +.Nm +.Op Ar +.Sh DESCRIPTION +The +.Nm +utility processes files ... +When no file arguments are given, +.Nm +will read from the standard input. +.Pp +The options are as follows: +.Bl -tag -width Ds +.It Fl h, \-help +Print help text and exit. +.It Fl \-version +Print version info and exit. +.El +.\" .Sh CONTEXT +.\" For section 9 functions only. +.\" .Sh IMPLEMENTATION NOTES +.\" Not used in OpenBSD. +.\" .Sh RETURN VALUES +.\" For sections 2, 3, and 9 function return values only. +.\" .Sh ENVIRONMENT +.\" For sections 1, 6, 7, and 8 only. +.\" .Sh FILES +.Sh EXIT STATUS +.\" For sections 1, 6, and 8 only. +.Nm +exits 0 on success, and 1 if an error occurs. +.\" .Sh EXAMPLES +.\" .Sh DIAGNOSTICS +.\" For sections 1, 4, 6, 7, 8, and 9 printf/stderr messages only. +.\" .Sh ERRORS +.\" For sections 2, 3, 4, and 9 errno settings only. +.\" .Sh SEE ALSO +.\" .Xr foobar 1 +.\" .Sh STANDARDS +.\" .Sh HISTORY +.Sh AUTHORS +Bob Polis +.\" .Sh CAVEATS +.\" .Sh BUGS +.\" .Sh SECURITY CONSIDERATIONS +.\" Not used in OpenBSD. diff --git a/premake.make b/premake.make new file mode 100644 index 0000000..db22f10 --- /dev/null +++ b/premake.make @@ -0,0 +1,31 @@ +# Define linker flags here, like: -lsqlite3 -lpthread +LDLIBS := -lscstring + +# Dir name becomes product name. +PROJ := $(shell basename $$(pwd)) + +# Find out what platform we're on, e.g. Darwin, Linux, OpenBSD. +UNAME_S := $(shell uname -s) + +# We will build a tool, not a library. +PRODUCT := tool + +# Single source of truth for version. +MAJOR := 1 +MINOR := 0 +PATCH := 0 + +# Specify desired C++ standard for this project. +CXXFLAGS += -std=c++20 + +# Set to 1 if you want a precompiled header for the C++ Standard Library. +PRECOMPILE := 0 + +# List of extra files to be installed in DATADIR (/usr/local/share/$(PROJ) by default) +DATAFILES := + +# Define plugin sub-projects here. Assumption here is a directory "plugins" +# containing plugin sub-projects, each in its own directory. +# Rename and/or repeat accordingly. +PLUGINS := $(wildcard plugins/*) +MAKE += --no-print-directory diff --git a/src/main.cpp b/src/main.cpp new file mode 100644 index 0000000..811c4ef --- /dev/null +++ b/src/main.cpp @@ -0,0 +1,74 @@ +#include +#include +#include +#include +#include +#include +#include +#include +#include "version.hpp" + +static void print_help() { + std::cout << "usage: valid-utf8 [-h]\n"; + std::cout << " -h, --help show this help text and exit\n"; + std::cout << " --version show version number and exit\n"; +} + +static int check_file(std::istream& file) { + std::string line; + while (std::getline(file, line)) { + if (!sc::is_valid_utf8(line)) return EXIT_FAILURE; + } + return EXIT_SUCCESS; +} + +int main(int argc, char * argv[]) { + try { + int opt_char, opt_val; + struct option long_options[] = { + {"help", no_argument, nullptr, 'h'}, + {"version", no_argument, &opt_val, 1}, + {nullptr, 0, nullptr, 0} + }; + while ((opt_char = getopt_long(argc, argv, "h", long_options, nullptr)) != -1) { + switch (opt_char) { + case 0: { + // handle long-only options here + switch (opt_val) { + case 1: + std::cout << valid_utf8_version() << std::endl; + return EXIT_SUCCESS; + } + break; + } + case 'h': + print_help(); + return EXIT_SUCCESS; + case '?': + throw std::runtime_error("unrecognized option"); + } + } + if (optind == argc) { + return check_file(std::cin); + } else if (optind == argc - 1) { + std::ifstream file {argv[optind]}; + if (!file) throw std::runtime_error {"could not open file"}; + return check_file(file); + } + for (int i = optind; i < argc; ++i) { + try { + // process file argv[i] + std::ifstream file {argv[i]}; + if (!file) throw std::runtime_error {std::string {"could not open file: "} + argv[i]}; + int ret = check_file(file); + if (ret == EXIT_FAILURE) throw std::runtime_error {std::string {"not valid utf8: "} + argv[i]}; + } catch (const std::runtime_error& ex) { + std::cerr << "valid-utf8: " << ex.what() << '\n'; + } + } + } catch (const std::exception& ex) { + std::cerr << "valid-utf8: " << ex.what() << '\n'; + return EXIT_FAILURE; + } + return EXIT_SUCCESS; +} diff --git a/src/precomp.hpp b/src/precomp.hpp new file mode 100644 index 0000000..182bcb4 --- /dev/null +++ b/src/precomp.hpp @@ -0,0 +1,127 @@ +// C++98 (first official C++ standard) +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#if (__cplusplus >= 201103L) // C++11 +#include +#include +#include +#include +#include +#include // deprecated in C++17, removed in C++26 +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#endif // C++11 + +#if (__cplusplus >= 201402L) // C++14 +#include +#endif // C++14 + +#if (__cplusplus >= 201703L) // C++17 +#include +#include +#include +#include +#include +#include +#include +#include +#endif // C++17 + +#if (__cplusplus >= 202002L) // C++20 +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +//#include not yet supported by clang 16 +//#include not yet supported by clang 17 +#include +#endif // C++20 + +#if (__cplusplus >= 202302L) // C++23 +#include +#include +#include +#include +#include +#include +#include +#include +#include +#endif // C++23 + +#if (__cplusplus > 202302L) // C++26 +#include +#include +#include +#include +#include +#include +#endif // C++26 diff --git a/src/version.cpp b/src/version.cpp new file mode 100644 index 0000000..5a277d2 --- /dev/null +++ b/src/version.cpp @@ -0,0 +1,19 @@ +#include "version.hpp" +#include "version.inc" +#include "commit.inc" +#include + +std::string valid_utf8_version() { + std::ostringstream oss; + oss << "valid-utf8 version " << version; +#ifdef DEBUG + oss << " DEBUG"; +#endif + oss << '\n'; + if (commit[0] != '\0') { + oss << "build " << commit << ", "; + } + oss << __DATE__ << ", " << __TIME__ << '\n'; + oss << "(c) Bob Polis, all rights reserved"; + return oss.str(); +} diff --git a/src/version.hpp b/src/version.hpp new file mode 100644 index 0000000..f38822b --- /dev/null +++ b/src/version.hpp @@ -0,0 +1,8 @@ +#ifndef VERSION_H_ +#define VERSION_H_ + +#include + +std::string valid_utf8_version(); + +#endif // VERSION_H_ diff --git a/tests/Makefile b/tests/Makefile new file mode 120000 index 0000000..d0b0e8e --- /dev/null +++ b/tests/Makefile @@ -0,0 +1 @@ +../Makefile \ No newline at end of file diff --git a/tests/postmake.make b/tests/postmake.make new file mode 100644 index 0000000..39e713a --- /dev/null +++ b/tests/postmake.make @@ -0,0 +1,6 @@ +$(BUILDDIR)/%.o: ../src/%.cpp +ifeq ($(PRECOMPILE), 1) + $(CXX) $(CXXFLAGS) -o $@ -include precomp.hpp -MMD -MP -MT $@ -MF $(BUILDDIR)/$*.dep -c $< +else + $(CXX) $(CXXFLAGS) -o $@ -MMD -MP -MT $@ -MF $(BUILDDIR)/$*.dep -c $< +endif diff --git a/tests/premake.make b/tests/premake.make new file mode 100644 index 0000000..d5cfa47 --- /dev/null +++ b/tests/premake.make @@ -0,0 +1,5 @@ +include ../premake.make +LDLIBS += -lboost_unit_test_framework +CXXFLAGS += -I../src +SRCS := $(notdir $(filter-out ../src/main.cpp,$(wildcard ../src/*.cpp))) +PRODUCT := tool diff --git a/tests/src/main.cpp b/tests/src/main.cpp new file mode 100644 index 0000000..533ab2a --- /dev/null +++ b/tests/src/main.cpp @@ -0,0 +1,8 @@ +#define BOOST_TEST_MODULE My Test +#define BOOST_TEST_DYN_LINK +#include + +BOOST_AUTO_TEST_CASE(first_test) +{ + BOOST_TEST(1 == 1); +} diff --git a/tests/src/precomp.hpp b/tests/src/precomp.hpp new file mode 120000 index 0000000..821bca7 --- /dev/null +++ b/tests/src/precomp.hpp @@ -0,0 +1 @@ +../../src/precomp.hpp \ No newline at end of file