bob/libscheaders
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects 4 Releases Wiki Activity

Iterators should not be reference parameters

Browse Source
This commit is contained in:
Bob Polis
2021-07-28 14:17:32 +02:00
parent acec279889
commit f1095f294a
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
functools.hpp
View File

@@ -44,21 +44,21 @@ namespace sc {
// iterator versions // iterator versions
template<class T, class M, class FwdIter> template<class T, class M, class FwdIter>
std::vector<M> map(FwdIter& begin, FwdIter& end, std::function<M(T)> fun) { std::vector<M> map(FwdIter begin, FwdIter end, std::function<M(T)> fun) {
std::vector<M> result; std::vector<M> result;
std::transform(begin, end, std::back_inserter(result), fun); std::transform(begin, end, std::back_inserter(result), fun);
return result; return result;
} }
template<class T, class FwdIter> template<class T, class FwdIter>
std::vector<T> filter(FwdIter& begin, FwdIter& end, std::function<bool(T)> fun) { std::vector<T> filter(FwdIter begin, FwdIter end, std::function<bool(T)> fun) {
std::vector<T> result; std::vector<T> result;
std::copy_if(begin, end, std::back_inserter(result), fun); std::copy_if(begin, end, std::back_inserter(result), fun);
return result; return result;
} }
template<class T, class R, class FwdIter> template<class T, class R, class FwdIter>
R reduce(FwdIter& begin, FwdIter& end, R seed, std::function<R(T, R)> fun) { R reduce(FwdIter begin, FwdIter end, R seed, std::function<R(T, R)> fun) {
R result {seed}; R result {seed};
for (FwdIter it = begin; it != end; ++it) { for (FwdIter it = begin; it != end; ++it) {
result = fun(*it, result); result = fun(*it, result);